[WIP] Support NWB Schema 2.9.0 #2092
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: rly <[email protected]> Co-authored-by: Steph Prince <[email protected]> Fix missing __nwbfields__ for NWBData (#2082)
…/pynwb into nwb-schema-2.9.0
Co-authored-by: rly <[email protected]>
…/pynwb into nwb-schema-2.9.0
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #2092 +/- ##
==========================================
+ Coverage 94.83% 94.95% +0.11%
==========================================
Files 28 28
Lines 2751 2832 +81
Branches 708 725 +17
==========================================
+ Hits 2609 2689 +80
- Misses 82 87 +5
+ Partials 60 56 -4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
* validate source_idx inputs for EventDetection * add tests for EventDetection schema updates * add 2D source index example for EventDetection * fix formatting and comments * update comments * update CHANGELOG * point to event detection schema branch * Update schema submodule --------- Co-authored-by: rly <[email protected]>
Co-authored-by: Steph Prince <[email protected]>
stephprince
approved these changes
Jun 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for upcoming NWB schema 2.9.0. This is a staging branch and will be merged into dev when all the 2.9.0 changes have been merged into here.